Add node-cron to server externals #68788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| buildDuration | 17.5s | 26.2s | |
| buildDurationCached | 8.7s | 7.3s | N/A |
| nodeModulesSize | 355 MB | 353 MB | N/A |
| nextStartRea..uration (ms) | 427ms | 432ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| 124-HASH.js gzip | 37.5 kB | 37.3 kB | N/A |
| 5121a57b-HASH.js gzip | 51.9 kB | 51.9 kB | N/A |
| 7480.HASH.js gzip | 169 B | 169 B | ✓ |
| 935-HASH.js gzip | 5.19 kB | 5.19 kB | N/A |
| framework-HASH.js gzip | 56.7 kB | 56.7 kB | ✓ |
| main-app-HASH.js gzip | 224 B | 225 B | N/A |
| main-HASH.js gzip | 32.5 kB | 32.1 kB | N/A |
| webpack-HASH.js gzip | 1.71 kB | 1.71 kB | ✓ |
| Overall change | 58.6 kB | 58.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 193 B | 194 B | N/A |
| _error-HASH.js gzip | 193 B | 192 B | N/A |
| amp-HASH.js gzip | 509 B | 511 B | N/A |
| css-HASH.js gzip | 342 B | 343 B | N/A |
| dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
| edge-ssr-HASH.js gzip | 265 B | 266 B | N/A |
| head-HASH.js gzip | 362 B | 364 B | N/A |
| hooks-HASH.js gzip | 393 B | 393 B | ✓ |
| image-HASH.js gzip | 4.4 kB | 4.4 kB | ✓ |
| index-HASH.js gzip | 268 B | 267 B | N/A |
| link-HASH.js gzip | 2.81 kB | 2.81 kB | N/A |
| routerDirect..HASH.js gzip | 329 B | 327 B | N/A |
| script-HASH.js gzip | 395 B | 396 B | N/A |
| withRouter-HASH.js gzip | 325 B | 323 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 6.74 kB | 6.74 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 748 B | 748 B | ✓ |
| Overall change | 748 B | 748 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| index.html gzip | 522 B | 521 B | N/A |
| link.html gzip | 537 B | 538 B | N/A |
| withRouter.html gzip | 518 B | 518 B | ✓ |
| Overall change | 518 B | 518 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 127 kB | 127 kB | N/A |
| page.js gzip | 168 kB | 168 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 669 B | 667 B | N/A |
| middleware-r..fest.js gzip | 155 B | 156 B | N/A |
| middleware.js gzip | 29.7 kB | 29.6 kB | N/A |
| edge-runtime..pack.js gzip | 1.03 kB | 1.03 kB | ✓ |
| Overall change | 1.03 kB | 1.03 kB | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| 928-experime...dev.js gzip | 322 B | 310 B | N/A |
| 928.runtime.dev.js gzip | 314 B | 301 B | N/A |
| app-page-exp...dev.js gzip | 307 kB | 245 kB | N/A |
| app-page-exp..prod.js gzip | 121 kB | 120 kB | N/A |
| app-page-tur..prod.js gzip | 133 kB | 132 kB | N/A |
| app-page-tur..prod.js gzip | 129 kB | 128 kB | N/A |
| app-page.run...dev.js gzip | 297 kB | 232 kB | N/A |
| app-page.run..prod.js gzip | 117 kB | 117 kB | N/A |
| app-route-ex...dev.js gzip | 28 kB | 23.1 kB | N/A |
| app-route-ex..prod.js gzip | 18.8 kB | 18.8 kB | N/A |
| app-route-tu..prod.js gzip | 18.8 kB | 18.8 kB | N/A |
| app-route-tu..prod.js gzip | 18.6 kB | 18.6 kB | N/A |
| app-route.ru...dev.js gzip | 29.7 kB | 24.4 kB | N/A |
| app-route.ru..prod.js gzip | 18.6 kB | 18.6 kB | N/A |
| pages-api-tu..prod.js gzip | 9.6 kB | 9.6 kB | ✓ |
| pages-api.ru...dev.js gzip | 11.4 kB | 9.87 kB | N/A |
| pages-api.ru..prod.js gzip | 9.59 kB | 9.59 kB | ✓ |
| pages-turbo...prod.js gzip | 21.6 kB | 21.6 kB | N/A |
| pages.runtim...dev.js gzip | 27.5 kB | 22.2 kB | N/A |
| pages.runtim..prod.js gzip | 21.6 kB | 21.6 kB | N/A |
| server.runti..prod.js gzip | 56.8 kB | 56.7 kB | N/A |
| Overall change | 19.2 kB | 19.2 kB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js 08-12-add_node-cron_to_server_externals | Change | |
|---|---|---|---|
| 0.pack gzip | 1.42 MB | 1.42 MB | |
| index.pack gzip | 120 kB | 120 kB | N/A |
| Overall change | 1.42 MB | 1.42 MB |
Diff details
Diff for page.js
Diff too large to display
Diff for middleware.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
Diff for image-HASH.js
@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[8358],
{
- /***/ 8316: /***/ (
+ /***/ 8834: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/image",
function () {
- return __webpack_require__(4765);
+ return __webpack_require__(5780);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 1112: /***/ (module, exports, __webpack_require__) => {
+ /***/ 7481: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -40,17 +40,17 @@
__webpack_require__(5596)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(9382)
+ __webpack_require__(9639)
);
- const _getimgprops = __webpack_require__(2097);
- const _imageconfig = __webpack_require__(8714);
- const _imageconfigcontextsharedruntime = __webpack_require__(1327);
- const _warnonce = __webpack_require__(6055);
- const _routercontextsharedruntime = __webpack_require__(8275);
+ const _getimgprops = __webpack_require__(1607);
+ const _imageconfig = __webpack_require__(2867);
+ const _imageconfigcontextsharedruntime = __webpack_require__(1015);
+ const _warnonce = __webpack_require__(6694);
+ const _routercontextsharedruntime = __webpack_require__(9562);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(6067)
+ __webpack_require__(3463)
);
- const _usemergedref = __webpack_require__(1261);
+ const _usemergedref = __webpack_require__(1057);
// This is replaced by webpack define plugin
const configEnv = {
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
/***/
},
- /***/ 1261: /***/ (module, exports, __webpack_require__) => {
+ /***/ 1057: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -440,7 +440,7 @@
/***/
},
- /***/ 2097: /***/ (
+ /***/ 1607: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -456,9 +456,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(6055);
- const _imageblursvg = __webpack_require__(9254);
- const _imageconfig = __webpack_require__(8714);
+ const _warnonce = __webpack_require__(6694);
+ const _imageblursvg = __webpack_require__(9866);
+ const _imageconfig = __webpack_require__(2867);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -830,7 +830,7 @@
/***/
},
- /***/ 9254: /***/ (__unused_webpack_module, exports) => {
+ /***/ 9866: /***/ (__unused_webpack_module, exports) => {
"use strict";
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -885,7 +885,7 @@
/***/
},
- /***/ 9331: /***/ (
+ /***/ 3484: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -912,10 +912,10 @@
},
});
const _interop_require_default = __webpack_require__(4345);
- const _getimgprops = __webpack_require__(2097);
- const _imagecomponent = __webpack_require__(1112);
+ const _getimgprops = __webpack_require__(1607);
+ const _imagecomponent = __webpack_require__(7481);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(6067)
+ __webpack_require__(3463)
);
function getImageProps(imgProps) {
const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -947,7 +947,7 @@
/***/
},
- /***/ 6067: /***/ (__unused_webpack_module, exports) => {
+ /***/ 3463: /***/ (__unused_webpack_module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -982,7 +982,7 @@
/***/
},
- /***/ 4765: /***/ (
+ /***/ 5780: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -999,8 +999,8 @@
// EXTERNAL MODULE: ./node_modules/.pnpm/react@19.0.0-rc-06d0b89e-20240801/node_modules/react/jsx-runtime.js
var jsx_runtime = __webpack_require__(3262);
- // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-06d0b89e-20240801_re_432dyi3er6pnalgpduyz2i6axm/node_modules/next/image.js
- var next_image = __webpack_require__(2692);
+ // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-06d0b89e-20240801_re_wusbvjw3sleq6d7g7gklhdw6bm/node_modules/next/image.js
+ var next_image = __webpack_require__(8565);
var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
/* harmony default export */ const nextjs = {
src: "/_next/static/media/nextjs.cae0b805.png",
@@ -1030,12 +1030,12 @@
/***/
},
- /***/ 2692: /***/ (
+ /***/ 8565: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(9331);
+ module.exports = __webpack_require__(3484);
/***/
},
@@ -1045,7 +1045,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
- __webpack_exec__(8316)
+ __webpack_exec__(8834)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for link-HASH.js
@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[4644],
{
- /***/ 3809: /***/ (
+ /***/ 9251: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/link",
function () {
- return __webpack_require__(484);
+ return __webpack_require__(7234);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 9298: /***/ (module, exports) => {
+ /***/ 9580: /***/ (module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -110,7 +110,7 @@
/***/
},
- /***/ 8909: /***/ (module, exports, __webpack_require__) => {
+ /***/ 2876: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -122,7 +122,7 @@
return getDomainLocale;
},
});
- const _normalizetrailingslash = __webpack_require__(6010);
+ const _normalizetrailingslash = __webpack_require__(43);
const basePath =
/* unused pure expression or super */ null && (false || "");
function getDomainLocale(path, locale, locales, domainLocales) {
@@ -146,7 +146,7 @@
/***/
},
- /***/ 4300: /***/ (module, exports, __webpack_require__) => {
+ /***/ 8612: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -163,18 +163,18 @@
const _react = /*#__PURE__*/ _interop_require_default._(
__webpack_require__(6408)
);
- const _resolvehref = __webpack_require__(2381);
- const _islocalurl = __webpack_require__(952);
- const _formaturl = __webpack_require__(8919);
- const _utils = __webpack_require__(3149);
- const _addlocale = __webpack_require__(513);
- const _routercontextsharedruntime = __webpack_require__(8275);
- const _approutercontextsharedruntime = __webpack_require__(91);
- const _useintersection = __webpack_require__(3065);
- const _getdomainlocale = __webpack_require__(8909);
- const _addbasepath = __webpack_require__(9887);
- const _routerreducertypes = __webpack_require__(9298);
- const _usemergedref = __webpack_require__(1261);
+ const _resolvehref = __webpack_require__(2772);
+ const _islocalurl = __webpack_require__(6335);
+ const _formaturl = __webpack_require__(4997);
+ const _utils = __webpack_require__(8346);
+ const _addlocale = __webpack_require__(1365);
+ const _routercontextsharedruntime = __webpack_require__(9562);
+ const _approutercontextsharedruntime = __webpack_require__(6269);
+ const _useintersection = __webpack_require__(2610);
+ const _getdomainlocale = __webpack_require__(2876);
+ const _addbasepath = __webpack_require__(9513);
+ const _routerreducertypes = __webpack_require__(9580);
+ const _usemergedref = __webpack_require__(1057);
const prefetched = new Set();
function prefetch(router, href, as, options, appOptions, isAppRouter) {
if (false) {
@@ -184,11 +184,8 @@
return;
}
// We should only dedupe requests when experimental.optimisticClientCache is
- // disabled & when we're not using the app router. App router handles
- // reusing an existing prefetch entry (if it exists) for the same URL.
- // If we dedupe in here, we will cause a race where different prefetch kinds
- // to the same URL (ie auto vs true) will cause one to be ignored.
- if (!options.bypassPrefetchedCheck && !isAppRouter) {
+ // disabled.
+ if (!options.bypassPrefetchedCheck) {
const locale =
typeof options.locale !== "undefined"
? options.locale
@@ -602,7 +599,7 @@
/***/
},
- /***/ 3065: /***/ (module, exports, __webpack_require__) => {
+ /***/ 2610: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -615,7 +612,7 @@
},
});
const _react = __webpack_require__(6408);
- const _requestidlecallback = __webpack_require__(5586);
+ const _requestidlecallback = __webpack_require__(7509);
const hasIntersectionObserver =
typeof IntersectionObserver === "function";
const observers = new Map();
@@ -728,7 +725,7 @@
/***/
},
- /***/ 1261: /***/ (module, exports, __webpack_require__) => {
+ /***/ 1057: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -797,7 +794,7 @@
/***/
},
- /***/ 484: /***/ (
+ /***/ 7234: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -812,7 +809,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(3262);
/* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(9758);
+ __webpack_require__(6065);
/* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_link__WEBPACK_IMPORTED_MODULE_1__
@@ -843,12 +840,12 @@
/***/
},
- /***/ 9758: /***/ (
+ /***/ 6065: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(4300);
+ module.exports = __webpack_require__(8612);
/***/
},
@@ -858,7 +855,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
- __webpack_exec__(3809)
+ __webpack_exec__(9251)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for 124-HASH.js
Diff too large to display
Diff for main-HASH.js
Diff too large to display
Diff for 928-experime..ntime.dev.js
@@ -1,2 +1,2 @@
-"use strict";exports.id=928,exports.ids=[928],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":(module,exports1)=>{function connect(){}Object.defineProperty(exports1,"__esModule",{value:!0}),Object.defineProperty(exports1,"connect",{enumerable:!0,get:function(){return connect}}),("function"==typeof exports1.default||"object"==typeof exports1.default&&null!==exports1.default)&&void 0===exports1.default.__esModule&&(Object.defineProperty(exports1.default,"__esModule",{value:!0}),Object.assign(exports1.default,exports1),module.exports=exports1.default)}};
+"use strict";exports.id=928,exports.ids=[928],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":(e,t)=>{function o(){}Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"connect",{enumerable:!0,get:function(){return o}}),("function"==typeof t.default||"object"==typeof t.default&&null!==t.default)&&void 0===t.default.__esModule&&(Object.defineProperty(t.default,"__esModule",{value:!0}),Object.assign(t.default,t),e.exports=t.default)}};
//# sourceMappingURL=928-experimental.runtime.dev.js.map
\ No newline at end of fileDiff for 928.runtime.dev.js
@@ -1,2 +1,2 @@
-"use strict";exports.id=928,exports.ids=[928],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":(module,exports1)=>{function connect(){}Object.defineProperty(exports1,"__esModule",{value:!0}),Object.defineProperty(exports1,"connect",{enumerable:!0,get:function(){return connect}}),("function"==typeof exports1.default||"object"==typeof exports1.default&&null!==exports1.default)&&void 0===exports1.default.__esModule&&(Object.defineProperty(exports1.default,"__esModule",{value:!0}),Object.assign(exports1.default,exports1),module.exports=exports1.default)}};
+"use strict";exports.id=928,exports.ids=[928],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":(e,t)=>{function o(){}Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"connect",{enumerable:!0,get:function(){return o}}),("function"==typeof t.default||"object"==typeof t.default&&null!==t.default)&&void 0===t.default.__esModule&&(Object.defineProperty(t.default,"__esModule",{value:!0}),Object.assign(t.default,t),e.exports=t.default)}};
//# sourceMappingURL=928.runtime.dev.js.map
\ No newline at end of fileDiff for app-page-exp..ntime.dev.js
failed to diffDiff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
failed to diffDiff for app-page.runtime.prod.js
Diff too large to display
Diff for app-route-ex..ntime.dev.js
Diff too large to display
Diff for app-route-ex..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route.runtime.dev.js
Diff too large to display
Diff for app-route.ru..time.prod.js
Diff too large to display
Diff for pages-api.runtime.dev.js
Diff too large to display
Diff for pages-turbo...time.prod.js
Diff too large to display
Diff for pages.runtime.dev.js
Diff too large to display
Diff for pages.runtime.prod.js
Diff too large to display
Diff for server.runtime.prod.js
Diff too large to display
ijjk
approved these changes
Aug 12, 2024
|
I tried adding |
timneutkens
added a commit
that referenced
this pull request
Aug 13, 2024
…entation.ts (#68835) ## What? After the fix in #68788 there was a report that the change doesn't resolve the problem, turns out that's because it was importing the package in `instrumentation.ts`. I found that `serverExternalPackages` didn't apply to `instrumentation.ts` in Turbopack, this PR fixes that. Fixes #68101 (comment) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
ForsakenHarmony
pushed a commit
that referenced
this pull request
Aug 14, 2024
…entation.ts (#68835) ## What? After the fix in #68788 there was a report that the change doesn't resolve the problem, turns out that's because it was importing the package in `instrumentation.ts`. I found that `serverExternalPackages` didn't apply to `instrumentation.ts` in Turbopack, this PR fixes that. Fixes #68101 (comment) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
ForsakenHarmony
pushed a commit
that referenced
this pull request
Aug 15, 2024
…entation.ts (#68835) ## What? After the fix in #68788 there was a report that the change doesn't resolve the problem, turns out that's because it was importing the package in `instrumentation.ts`. I found that `serverExternalPackages` didn't apply to `instrumentation.ts` in Turbopack, this PR fixes that. Fixes #68101 (comment) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
ForsakenHarmony
pushed a commit
that referenced
this pull request
Aug 16, 2024
…entation.ts (#68835) ## What? After the fix in #68788 there was a report that the change doesn't resolve the problem, turns out that's because it was importing the package in `instrumentation.ts`. I found that `serverExternalPackages` didn't apply to `instrumentation.ts` in Turbopack, this PR fixes that. Fixes #68101 (comment) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures node-cron is not bundled as it uses dynamic code loading forking a child process.
Fixes #68101